Skip to content

Rubin/Roman filters, Synthpop Compatability, black hole binary fraction updates, and bug fixes#69

Open
nsabrams wants to merge 107 commits intomainfrom
dev
Open

Rubin/Roman filters, Synthpop Compatability, black hole binary fraction updates, and bug fixes#69
nsabrams wants to merge 107 commits intomainfrom
dev

Conversation

@nsabrams
Copy link
Collaborator

@nsabrams nsabrams commented Sep 19, 2025 •
edited
Loading

This PR includes the following

  • Inclusion of Rubin and Roman filters by creating interpolations between UBV filters and those respective filters
  • Support for orbital motion in lightcurves generated and refactor of refine_binary_events to use lightcurve.py functions and be compatible with updated BAGLE
  • Inclusion of SDSS filter support via Galaxia
  • Support for multiple filters to be analyzed at once in refine_events() by using a filt_dict
  • Changes and tutorial for compatibility with synthpop as a replacement for galaxia+perform_pop_syn in some cases
  • Black hole splitting to allow user to choose binary black hole fraction
    • Fixed bugs in base function
    • Added capability to run this via run.py and slurm scripts
    • Author: @nsabrams
  • Bug Fixes and Misc
    • Make Einstein radius more precise by using astropy constants
    • Added some asserts to verify companions are matched between primary and companion .h5 files (just for debugging, there was no issue)
    • Updated test_synthetic.py multiplicity fraction and CO fraction. The code that produced these didn't change, but it appears that the numpy seed generation changed causing the fractions to shift by 1-2%.

Macy Huston and others added 30 commits June 27, 2024 13:06
fix issue with __expand in ebf due to binary vs. string formats
50cc734
start synthpop testing/example
2e486f8
allow for non-access to spisea git
e98f934
@hustonm
temporarily remove sythpop tutorial
a913670
@hustonm
restore synthpop tutorial in progress
e634a9b
@nsabrams
add support for SDSS filters
ba252c0
@nsabrams
switch einstein_radius to use astropy constants
856b5c4
@nsabrams
make einstein radius more precise
6891dcd
@SRemulla
adding rubin transformations
71c6205
@nsabrams
switch to astropy builtin ephem for bagle
e2bf1e5
@SRemulla
generated ubv to rubin + roman grids
516fa46
@SRemulla
switched ukirt to ubv when indexing in synthetic
d1b6eab
tweaks for synthpop compatibility
609a36e
@SRemulla
wrote required filters exceptions for transform_ubv_to_rubin
ce9d09c
@SRemulla
correcting roman filt list to include wfi
14b2254
synthpop compatibility progress / tutorial needs cleanup
09795f3
@SRemulla
Merge pull request #66 from jluastro/add_rubin_roman
d505aba 
Add Rubin and Roman
@nsabrams
fixed binary black hole separation function
5ce9575
@nsabrams
Merge branch 'dev' of github.com:jluastro/PopSyCLE into dev
820bc1b
@nsabrams
add asserts to make sure companion table matches number of recorded p…
fb796e4 
…rimaries with companions
@nsabrams
fix nonetype issue
eb91d14
@nsabrams
add lock to isochrone generation
1bf8c95
@nsabrams
another assert bugfix
890aa0d
@SRemulla
fixed rubin y transformation bugs in synthetic
f5ca254
@SRemulla
added filter_dict option to check_refine_events
d964761
@SRemulla
changed refine_events to use dictionary for photometric systems and f…
f5eb75c 
…ilters
@SRemulla
corrected refine_events .fits file name
715ec0a
@SRemulla
fixed more bugs pertaining to rubin y band transform in synthetic
8735e98
@SRemulla
restored option for single band in refine events
9f9be08
working synthpopsycle notebook
8fe9d50
nsabrams and others added 30 commits October 17, 2025 09:26
@nsabrams
more doc updates
b52a86f
@nsabrams
more doc updates
41e1a21
@SRemulla
updated _return_filename_dict for multi filt
4d45687
@SRemulla
fixed issue where perform_pop_syn generated unwanted filters
4662bda
@SRemulla
fixed filename_dict within generate_slurm_config
8cc2bd0
@nsabrams
fix additional phot systems in make_bhs_single
c6db60d
update synthpop tutorial for filter_dict
400fd13
@jluastro
nothing much
381c723
@jluastro
Merging
d19bc31
@jluastro
old changes
0aa765e
@jluastro
merging
0c13a3d
@jluastro
useful table utilities
59d6c84
@jluastro
merging
adc9f3f
@nsabrams
added ability to return param dicts and names
63980fc
@nsabrams
fixed merge conflicts
e5c472e
@nsabrams
moved cut_Mruns to table utils
830574c
@nsabrams
added functions to combine output tables
3480620
@SRemulla
incorporate filter_dict to model params
facb0bc
@SRemulla
fixed HIERARCH typo
4851855
@SRemulla
switched refine_binary_events input to filter_dict
2d1fb99
@SRemulla
added filter_dict to synthetic and fixed save_phot
daced25
@SRemulla
fixed bianary typo :)
a68cdd7
@SRemulla
update to use filter_dict
950deb2
@SRemulla
changed phot sys to filter_dict
fac46ea
@nsabrams
Merge branch 'dev' into multi_filt_bagle_models
7f6fb4b
@SRemulla
merge nothing github issue
2140482
@SRemulla
resolve merge conflict
2f0fa01
@nsabrams
Clean up comments in lightcurves.py
a7bf03e
@nsabrams
Clean up comments in synthetic.py
a011f0d
@nsabrams
Merge pull request #75 from MovingUniverseLab/multi_filt_bagle_models
e3b876d 
Incorporates multi-filter capabilities for the bagle models inside the saved photometry.

The bagle model parameters are now saved inside a BinTableHDU, as the fits header was too small to allow more filters
filter_dict is now required for refine_binary_events
lightcurves.py functions now require filter_dict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nsabrams @hustonm @SRemulla @jluastro